Add port 8889#748
Conversation
Add port 8889 on deployment to export span-metrics Signed-off-by: agueijo <agueijo@gmail.com>
There was a problem hiding this comment.
Pull request overview
This PR adds port 8889 to the Jaeger deployment container spec to expose span-metrics from the collector.
Changes:
- Added container port 8889 (TCP) to the Jaeger deployment template alongside the existing port 8888.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| protocol: TCP | ||
| - containerPort: 8888 | ||
| protocol: TCP | ||
| - containerPort: 8889 |
There was a problem hiding this comment.
The existing port 8888 and other ports in this file likely have a name field to identify their purpose (e.g., for use in Service selectors or readability). This new port entry is missing a name field. Consider adding a descriptive name such as span-metrics to be consistent with the other port definitions and to make it clear what this port is used for.
| - containerPort: 8889 | |
| - containerPort: 8889 | |
| name: span-metrics |
|
this should not be required. This PR already exposed the necessary service port 240e4a0 We are currently using prometheus to store span metrics since this PR went in. Also the containerPort does nothing. 
|
|
This can be merged though with no harm and is still good information to add. |
Add port 8889 on deployment to export span-metrics
What this PR does
Which issue this PR fixes
(optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format,will close that issue when PR gets merged)
Checklist
[jaeger]or[jaeger-operator])